Skip to content

[2302] Bug: Incorrect VM IP Warning After Revalidation #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AbhijeetThakur wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[2302] Bug: Incorrect VM IP Warning After Revalidation #2339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ui/src/features/migration/hooks/useVmsSelectionState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,11 +382,18 @@ export function useVmsSelectionState(props: VmsSelectionStepProps) {
allIPs = existingVm.ipAddress ?? allIPs
}

let preferredNetworkInterfaces = vm.networkInterfaces
if (existingVm && existingVm.networkInterfaces && existingVm.networkInterfaces.length > 0) {
preferredNetworkInterfaces = existingVm.networkInterfaces
// Base is the freshly fetched NIC list (source of truth for IP presence, e.g. after
// revalidate). Only override per-NIC ipAddress where the user made a custom
// assignment (preserveIp[i] === false) — never blanket-keep the stale existing list,
// or newly-discovered IPs after a revalidate would never surface.
let preferredNetworkInterfaces = normalizeNetworkInterfaces(vm.networkInterfaces)
if (existingVm?.networkInterfaces?.length) {
preferredNetworkInterfaces = mergeNicIpOverrides(
preferredNetworkInterfaces ?? [],
normalizeNetworkInterfaces(existingVm.networkInterfaces) ?? [],
existingVm.preserveIp ?? {},
)
}
preferredNetworkInterfaces = normalizeNetworkInterfaces(preferredNetworkInterfaces)

return {
...vm,
Expand Down
Loading