Adaption to be an Arduino shield - #4
Open
zlite wants to merge 8 commits into
Open
Conversation
added 6 commits
March 29, 2020 21:05
… now just a regular Arduino shield
platisd
requested changes
Apr 18, 2020
platisd
left a comment
platisd
left a comment
Owner
There was a problem hiding this comment.
Looks good, but I'd like to keep SonicDisc as a standalone module too. I suggest instead of changing the entire project to a shield, to add the shield "on the side" (i.e. name the modified files differently).
The firmware can perhaps stay in the same file with the addition of some #ifdef SONICDISC_SHIELD?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version just modifies the original to work with the Arduino shield version of the hardware. Does not require I2C polling, writes results to the Arduino serial port and uses the correct LED pin