Fix SOGS rendering scenes with SH 1 or 2 #7703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WGSL (playcanvas#7702) Co-authored-by: Martin Valigursky <[email protected]>
|
Thanks for the PR, @vincentwoo! Would you be able to pop a PR description up too please? Thanks! 🙏 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes rendering issues with SOGS scenes by introducing overloaded versions of the readSHData function to handle different spherical harmonics (SH) vector depths.
- Added a comment clarifying the function overload rationale.
- Introduced two new overloads of readSHData for SH vector sizes of 8 and 3.
| @@ -19,4 +21,30 @@ void readSHData(in SplatSource source, out vec3 sh[15], out float scale) { | |||
|
|
|||
| scale = 1.0; | |||
| } | |||
|
|
|||
| void readSHData(in SplatSource source, out vec3 sh[8], out float scale) { | |||
There was a problem hiding this comment.
[nitpick] Overloading readSHData based solely on the out array length may lead to future confusion in overload resolution. Consider adding explicit comments or using distinct function names to clarify the intended usage of each overload.
Suggested change
| void readSHData(in SplatSource source, out vec3 sh[8], out float scale) { | |
| // Reads SH data for 8 coefficients | |
| void readSHData8(in SplatSource source, out vec3 sh[8], out float scale) { |
Copilot uses AI. Check for mistakes.
mvaligursky
reviewed
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOGS scenes with SH 1 or 2 do not render currently, owing to missing handlers for their spherical harmonics.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.