-
Notifications
You must be signed in to change notification settings - Fork 56
Streaming SOG loading updates #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances streaming SOG (Gaussian Splat) loading in unified rendering mode and adds support for hiding annotations in noui mode. The changes ensure proper frame rendering synchronization by waiting for streaming data to settle before invoking the first frame event.
Key changes:
- Implements event-driven waiting for streaming SOG loading to complete before firing the first frame event
- Conditionally creates annotations only when UI is enabled (
!config.noui) - Adds forced rendering during streaming load to ensure unified rendering updates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Cannot say I like this. In a way it removed part of reason for streaming LODs if we need to wait for all of that to be loaded. |
|
Maybe initially it should use low quality lod range (say the bottom 2 LODs). When those are loaded, start rendering, but enable further LODs? |
|
Sure we can consider all this later along with reveal effects later. |
mvaligursky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok, but as mention in comment before, this needs further work before release.
This PR:
nouimode