Skip to content

Conversation

@slimbuck
Copy link
Member

This PR:

  • waits for streaming SOG loading to settle before invoking first frame
  • hide annotations in noui mode

@slimbuck slimbuck requested review from a team and Copilot November 24, 2025 11:07
@slimbuck slimbuck self-assigned this Nov 24, 2025
@slimbuck slimbuck added the enhancement New feature or request label Nov 24, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances streaming SOG (Gaussian Splat) loading in unified rendering mode and adds support for hiding annotations in noui mode. The changes ensure proper frame rendering synchronization by waiting for streaming data to settle before invoking the first frame event.

Key changes:

  • Implements event-driven waiting for streaming SOG loading to complete before firing the first frame event
  • Conditionally creates annotations only when UI is enabled (!config.noui)
  • Adds forced rendering during streaming load to ensure unified rendering updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mvaligursky
Copy link

  • waits for streaming SOG loading to settle before invoking first frame

Cannot say I like this. In a way it removed part of reason for streaming LODs if we need to wait for all of that to be loaded.

@mvaligursky
Copy link

Maybe initially it should use low quality lod range (say the bottom 2 LODs). When those are loaded, start rendering, but enable further LODs?

@slimbuck
Copy link
Member Author

Sure we can consider all this later along with reveal effects later.

Copy link

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok, but as mention in comment before, this needs further work before release.

@slimbuck slimbuck merged commit 1cb431f into main Nov 24, 2025
2 checks passed
@slimbuck slimbuck deleted the lod-dev branch November 24, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants