More streaming tweaks #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refines the streaming quality system by introducing platform-specific configurations and resolution limits. The changes aim to optimize performance on both mobile and desktop devices by tailoring quality settings and preventing excessive rendering resolutions.
Key Changes:
- Introduces resolution limiting logic to cap rendering at ~3K for desktop and HD (1920) for mobile
- Restructures quality ranges with distinct configurations for mobile vs desktop platforms
- Changes default
hqModetotruefor all platforms (previouslyfalsefor mobile)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/viewer.ts | Adds platform import, implements resolution limiting logic in updateHqMode(), and restructures quality ranges to have separate mobile/desktop configurations with different LOD ranges and splat budgets |
| src/index.ts | Removes unused platform import and sets default hqMode to true for all devices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: