Skip to content

Fix default post-processing brightness (0 → 1)#880

Merged
abstrakt8 merged 2 commits into
mainfrom
copilot/update-default-brightness-to-1
May 11, 2026
Merged

Fix default post-processing brightness (0 → 1)#880
abstrakt8 merged 2 commits into
mainfrom
copilot/update-default-brightness-to-1

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 3, 2026

grading.brightness defaulted to 0 (black), making post-processing produce a completely black scene when enabled. The neutral/identity default should be 1, consistent with contrast and saturation which already default to 1.

// src/splat-serialize.ts
grading: { enabled: false, brightness: 1, contrast: 1, saturation: 1, tint: [1, 1, 1] },
Original prompt

Repository: playcanvas/supersplat

Goal: Create a pull request that changes the default post-processing brightness from 0 to 1.

Details:

  • Update defaultPostEffectSettings in src/splat-serialize.ts so that grading.brightness defaults to 1 instead of 0.
  • Keep all other default settings unchanged.
  • Ensure TypeScript formatting/linting remains consistent with the existing file.
  • Add a concise PR title and description explaining the change and why.

Reference file and commit:

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Can you change the default brightness to 1 and create a pullr equest

Assistant: I’m waiting for your confirmation in the GitHub dialog to proceed with creating the pull request that changes defaultPostEffectSettings.grading.brightness from 0 to 1.

This pull request was created from Copilot chat.

Copilot AI changed the title [WIP] Update default post-processing brightness to 1 Fix default post-processing brightness (0 → 1) May 3, 2026
Copilot AI requested a review from abstrakt8 May 3, 2026 10:57
@abstrakt8 abstrakt8 marked this pull request as ready for review May 3, 2026 10:58
@abstrakt8 abstrakt8 requested a review from slimbuck May 3, 2026 10:58
@abstrakt8
Copy link
Copy Markdown
Contributor

In Studio, the brightness would always be default to 0, which would make the screen dark

@abstrakt8 abstrakt8 merged commit 5b6b8ee into main May 11, 2026
2 checks passed
@abstrakt8 abstrakt8 deleted the copilot/update-default-brightness-to-1 branch May 11, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants