Skip to content

Preserve color picker hue when selecting white#892

Draft
Bortlesboat wants to merge 1 commit into
playcanvas:mainfrom
Bortlesboat:codex/preserve-white-picker-hue-818
Draft

Preserve color picker hue when selecting white#892
Bortlesboat wants to merge 1 commit into
playcanvas:mainfrom
Bortlesboat:codex/preserve-white-picker-hue-818

Conversation

@Bortlesboat
Copy link
Copy Markdown

Summary

  • add a local ColorPicker wrapper that restores the previous hue for achromatic RGB selections
  • route Supersplat color pickers through the wrapper so selecting white no longer resets the hue UI to red

Fixes #818

Testing

  • npm run build
  • npm run lint

@slimbuck
Copy link
Copy Markdown
Member

Thanks for this! However I'd rather fix this directly in https://github.com/playcanvas/pcui/blob/main/src/components/ColorPicker/index.ts so that everyone can benefit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting pure white resets hue in color picker

2 participants