Use splat hashes for editor overwrite and publish flows#912
Merged
Conversation
slimbuck
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the publish/overwrite flow to use splat hashes instead of internal splat IDs, aligning editor overwrite, settings, and republish behavior around the hash identifier.
Changes:
- Removed
Scene.idandPublishSettings.overwriteId. - Updated settings fetch/update and republish calls to use
overwriteHash. - Stopped passing
overwriteIdfrom the publish settings dialog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/publish.ts |
Switches publish, republish, and settings flows from internal IDs to hashes. |
src/ui/publish-settings-dialog.ts |
Resolves publish settings with overwriteHash only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Re-qi
pushed a commit
to Re-qi/ReSplat
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hashconsistently when loading existing scene settings and republishingoverwriteIdthrough the publish settings dialogTesting
npm run lintpassednpm run buildpassed