-
Notifications
You must be signed in to change notification settings - Fork 12
Metrics Output Plugin #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 67.59% 67.74% +0.15%
==========================================
Files 88 90 +2
Lines 9275 9425 +150
Branches 1294 1317 +23
==========================================
+ Hits 6269 6385 +116
- Misses 2981 3015 +34
Partials 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/canary |
Since this is a new feature I would probably call this a minor? |
|
||
Determines the name of the file to write. Defaults to `metrics`. | ||
|
||
### `rootProperties?` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this static metadata or can it be dynamic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent is moreso where this data shows up (at the root level). It /should/ support whatever, theoretically.
language/metrics-output-plugin/src/__tests__/metrics-output-plugin.test.ts
Outdated
Show resolved
Hide resolved
language/metrics-output-plugin/src/__tests__/metrics-output-plugin.test.ts
Outdated
Show resolved
Hide resolved
/canary |
/canary |
Build InfoYour PR was successfully deployed by CircleCI #4746 on
|
Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
Release Notes
Added new metrics output LSP plugin, to use it:
📦 Published PR as canary version:
0.10.3--canary.213.4746
Try this version out locally by upgrading relevant packages to 0.10.3--canary.213.4746