Drop unnecessary IFS magic#2459
Closed
plengauer wants to merge 4 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes an unnecessary local IFS (Internal Field Separator) override in the otel_observe() function. The IFS configuration was redundant because the _otel_dollar_star() helper function already sets its own local IFS when processing the command arguments, making the outer scope IFS override unnecessary.
Key Changes:
- Removed redundant IFS override from
otel_observe()function
auto-merge was automatically disabled
November 15, 2025 16:52
Pull request was converted to draft
moflwi
previously approved these changes
Nov 30, 2025
Fix IFS variable assignment in otel_observe function.
actions-bot-pl
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.