Fix missing exec parent spans in docker environments#2694
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical issue where parent spans were being dropped in Docker environments due to multiple processes sharing the SDK and having SPAN_AUTO_END reset on subsequent span starts. The fix replaces direct _otel_sdk_communicate 'SPAN_AUTO_END' calls with _otel_end_script and updates shell invocations to use $_otel_shell instead of hardcoded sh.
Key changes:
- Replace
_otel_sdk_communicate 'SPAN_AUTO_END'with_otel_end_scriptto properly handle span cleanup - Update shell invocations from hardcoded
shto$_otel_shellvariable for consistency - Apply fixes across three exec injection functions
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
actions-bot-pl
previously approved these changes
Dec 17, 2025
moflwi
approved these changes
Dec 19, 2025
actions-bot-pl
pushed a commit
that referenced
this pull request
Dec 19, 2025
Co-authored-by: Philipp Lengauer <100447901+plengauer@users.noreply.github.com>
actions-bot-pl
added a commit
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parent spans got dropped because several processes share SDK and SPAN_AUTO_END was reset on next span start