remove not needed global #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorsradek
force-pushed
the
support-different-globals2
branch
from
09055b4 to
bfcd3f2
Compare
Comment on lines
+38
to
+41
| # Removes the .terraform suffix if it exists | ||
| if [[ "$KEY" == *".terraform" ]]; then | ||
| KEY=${KEY%".terraform"} | ||
| fi |
There was a problem hiding this comment.
Actually, I think this we don't need anymore, right? 🤔 And existing properties don't have it if I remember correctly since they weren't terraformed, but we should double check
There was a problem hiding this comment.
yeah, not sure. Let's remove with all the others. I will add TODOs
maximelaboisson
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to parse global as we don't expect it in the path