Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove application.<anything>. prefix #19

Conversation

dorsradek
Copy link
Contributor

No description provided.

Copy link

linear bot commented Aug 28, 2024

@dorsradek dorsradek force-pushed the feature/sre-6001-add-new-key-to-shared-configuration-for-services branch from 6adf084 to 50bb0a5 Compare August 28, 2024 17:44
@dorsradek dorsradek force-pushed the feature/sre-6001-add-new-key-to-shared-configuration-for-services branch from 50bb0a5 to c10c039 Compare August 28, 2024 17:45
@dorsradek dorsradek marked this pull request as ready for review August 28, 2024 17:46
@dorsradek dorsradek requested a review from bpesics August 28, 2024 17:46
@@ -4,5 +4,6 @@ launch-darkly.key=secret_value
msk.endpoint=https://msk.com
openai.key=beepboop
private=password
redis.kerberos-authz.url=kerberos-authz.cache.dev.pleo.io
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an entry to test for arrays too, like what jens wants to do? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works 💣

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality software

@dorsradek dorsradek force-pushed the feature/sre-6001-add-new-key-to-shared-configuration-for-services branch from 61f7300 to 289500d Compare August 28, 2024 17:51
Copy link
Collaborator

@maximelaboisson maximelaboisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dorsradek dorsradek merged commit 8b54872 into main Aug 28, 2024
2 checks passed
@dorsradek dorsradek deleted the feature/sre-6001-add-new-key-to-shared-configuration-for-services branch August 28, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants