Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Add flag to ignore undefined properties #1

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

elleFlorio
Copy link

Add the ignore_undefined flag to ignore properties that are not
defined in the dbt file. If the ignore_undefined flag is set
the JSON payload sent to the api request in Metabase will
contain only properties that are not None in the dbt file.

Example:

  • ignore_undefined = true and 'special_type' is None:
    Metabase special type won't be changed
  • ignore_undefined = false and 'special_type' is None:
    Metabase special type will be removed

Luca Florio added 2 commits March 8, 2021 16:43
Add the ignore_undefined flag to ignore properties that are not
defined in the dbt file. If the ignore_undefined flag is set
the json paylod sent to the api requrest in metabase will
contain only properties that are not None in the dbt file.

Example:
- ignore_undefined = true and 'special_type' is None:
	Metabase special type won't be changed
- ignore_undefined = false and 'special_type' is None:
	Metabase special type will be removed
@elleFlorio elleFlorio requested a review from a team March 12, 2021 08:39
Copy link

@ecray ecray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elleFlorio elleFlorio merged commit d3b9177 into master Mar 12, 2021
@elleFlorio elleFlorio deleted the feat/ignore-undefined-metadata branch March 12, 2021 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants