-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEG-4936 migrate to pleo gradle plugin #232
Conversation
❤️ Good work! 📚 📄 PR checks are defined in our Dangerfile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of leg-work, thanks so much!
I wonder if the publication to Maven still works with this?
# Conflicts: # .github/workflows/format-kotlin.yaml
@@ -184,3 +191,7 @@ coverallsJacoco { | |||
tasks.named('coverallsJacoco') { | |||
dependsOn jacocoAggregatedReport | |||
} | |||
|
|||
//tasks.named('check') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erwinw I've been struggling to add support of kotlinter pre commit push hook and haven't succeeded yet. If you would have some time to take a look, I'd appreciate 🙏
It seems like the assign random codeowners step does not work because it's a public repo that does not have access to the private pleo-io/assign-random-codeowners repo, @andriygg . |
I've removed this workflow as well. But all other work for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks so much!
@erwinw would you have some time to look at configuration of the kotlinter precommit hook? I've spent some amount of time and still cannot register it for the root project |
Would this approach work? |
That is right approach for sure, but the problem is that I'm getting error A problem occurred evaluating root project 'prop'.
> Task with name 'check' not found in root project 'prop'. when include depends on for check task tasks.named('check') {
dependsOn 'installKotlinterPrePushHook'
} I've tried a few approached to fix it up, but looks like I'm missing something. So that's why I'm asking if you'd have some time to take a look. It should be something trivial |
Ah I see. Sure, I'll have a look! |
Linear story: PEG-4936
Have you done ...