Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Install pre-commit hook for linting #241

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

erwinw
Copy link
Member

@erwinw erwinw commented Jan 30, 2024

Install pre-commit hook for linting

@erwinw erwinw requested review from a team and andriygg January 30, 2024 10:25
Copy link
Contributor

@andriygg andriygg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @erwinw , I'm still a bit concerned why installKotlinterPrePushHook cannot be registered, even though it's available in the list gradlew tasks

build.gradle Outdated
}

tasks.create('check') {
dependsOn installLocalGitHooks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you found why installKotlinterPrePushHook from kotlinter doesn't work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I didn't realise installKotlinterPrePushHook was a feature kotlinter came with. It does work like this, so I've moved to using that instead!

@erwinw erwinw enabled auto-merge (squash) January 30, 2024 11:34
@erwinw erwinw self-assigned this Jan 30, 2024
@erwinw erwinw requested a review from danieldisu January 30, 2024 11:35
@erwinw erwinw merged commit a105b8c into main Jan 30, 2024
10 checks passed
@erwinw erwinw deleted the chore/pre-commit-hook branch January 30, 2024 13:21
@erwinw erwinw requested review from ibywaks and removed request for ibywaks February 2, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants