Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-2447] Rollout new renovate process #28

Merged
merged 1 commit into from
May 27, 2024

Conversation

Niceplace
Copy link
Contributor

This PR includes all the necessary changes for this repository to use the new Renovate setup. With this new setup, you'll get the following:

  • Shorten cycle time for pull requests. Thanks to enabling merge queues.
  • Full control over when Renovate runs for your repo. It now runs as a scheduled (or on-demand) GH workflow on your repo.

And now, the details about the changes on this PR:

  • Add the renovate_dependency_management.yaml GH workflow, which will run Renovate for this repo at a schedule, or on demand (for this we also need to bump to a recent centralized-templates version).
  • Add the schedule of when Renovate will run for your repo. Our proposal is to run it once in the morning from Mon-Fri, but you can tweak it if needed.
  • Remove grouping for minor and patch dependencies. With the optimized Renovate setup, where cycle time for Renovate PRs is much shorter, we don't see a need for it. Additionally, it was causing problems as some repos ended up with failing PRs that bundled dozens of dependencies, and troubleshooting them was a nightmare.
  • For the repos where only 1 code reviewer approval is needed, we remove the unnecessary Kodiak setup.
  • Point to the default.json5 Renovate global preset in renovate-config repo.
  • Rename Renovate config from .json to .json5, so you can add explanatory comment to any custom config you need for your repo
  • Clean up of the repo custom Renovate config, by removing entries that are not needed, or already present in the global Renovate preset in renovate-config.

Apart from these changes, over the next couple days, we will take care of enabling merge queues for this repo.
If you are concerned about any changes, please comment here or reach out to
#ask-devx.

@Niceplace Niceplace self-assigned this May 24, 2024
Copy link

linear bot commented May 24, 2024

@Niceplace Niceplace requested a review from a team May 24, 2024 13:21
@Niceplace
Copy link
Contributor Author

Hey folks, I enabled branch protection rules for this repository but kept it quite light, I also ensured that the webcore team has the possibility to bypass them since you are repository admins. These settings are necessary for us to enable merge queues later on (after this PR & the subsequent file-distributor one is merged).

If you want to review the branch protection settings currently in place you can have a look here: https://github.com/pleo-io/s3-cache-action/settings/branches

Let us know if you have any questions, cheers !

@VictorPascualV VictorPascualV merged commit 86d04d6 into main May 27, 2024
7 of 9 checks passed
@VictorPascualV VictorPascualV deleted the feature/devx-2447-rollout-new-renovate-process branch May 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants