fix: Support turbo hash in preview deploy URLs #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macko911
changed the title
macko911
force-pushed
the
support-turbo-hash-preview-deploy
branch
from
b4bfeba to
1361200
Compare
Catchpowle
approved these changes
Sep 11, 2024
Merged
macko911
changed the title
macko911
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-1450: Support skipping app deployment on unrelated changes
Turbo hash has 16 instead of 40 characters, so we need to adjust the regex to accept both.
Old supported hash url: https://preview-6cd2b32ea72366adf21679cb796646184becd012.stories.dev.pleo.io/
New supported hash url: https://preview-ded26a748cdb93f8.stories.dev.pleo.io/
Also due to a TS error I've adjusted the tsconfig to use settings recommended for Node 18 based on these docs
I've confirmed that we use Node 18 for the edge lambdas here