feat: Add support for deploying Telescope using spa-tools #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macko911
force-pushed
the
web-1796-fix-telescope-feature-deploys
branch
from
09ebf39 to
7536cf3
Compare
tkloht
approved these changes
Feb 6, 2025
| // - true, we append index.html to the original request URI | ||
| // - false, we serve the top-level index.html file, as all the routing is handled client-side. | ||
| if (serveNestedIndexHtml) { | ||
| return request.uri.replace(/\/$/, '') + '/index.html' |
There was a problem hiding this comment.
don't we need to consider the json files generated by gatsby (or other SSGs) for navigation after initial load?
There was a problem hiding this comment.
Wouldn't those be handled by the previous condition isFileRequest?
Frankly I'm not loving that we are handling this ourselves this way but is seems to have served us well so far.
There was a problem hiding this comment.
yeah you're right, didn't make a lot of sense what I wrote - this is only for rewriting paths where we don't have a file.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/pleo/issue/WEB-1796/fix-telescope-feature-deploys
We want to fix Telescope website feature deploys by using
spa-toolsfor build and deploy.What's changed
Telescope build relies on having NOTION_API_KEY env variable.
Add support for having multiple nested index.html files in the app by using a new variable
serve_nested_index_htmlin the Terraform module.Telescope uses Gatsby SSG (static site generation) and pre-renderes static
index.htmlfor each route.Before this change if we go to https://telescope.pleo.io/components/overview/overview.about, we get the root
/index.htmlfile served from the S3 bucket.After these changes we get
/components/overview/overview.about/index.htmlfrom the S3 bucket.We now use
mime-typelibrary to detect if a requested URL is for a file. Until now we were naively checking that the last part of a pathname has a dot.in it, so URL/components/overview/overview.aboutwas considered to request a static file.Output "permanent" preview url from the deploy reusable workflow. This is used to update PR description with the preview link in a custom way compared to the way we do it in Web repo.