Skip to content

Add vertical round robining for dialogs where it fits #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

pannal
Copy link
Contributor

@pannal pannal commented Jul 6, 2018

GHI (If applicable): #

Description:

Add round robining on dialog(s) where it makes sense. Unify episodes view options dropdown behaviour by closing it on left instead of top.

Checklist:

  • I have based this PR against the develop branch

@pannal pannal changed the title Add round robining on player settings dialog list Add vertical round robining settings/options/dropdown dialog list Jul 6, 2018
@pannal pannal changed the title Add vertical round robining settings/options/dropdown dialog list Add vertical round robining for dialogs where it fits Jul 6, 2018
@pannal pannal force-pushed the pr_plsettings_roundrobin branch from 66eb6b7 to 43a8bfd Compare July 6, 2018 20:33
@pannal
Copy link
Contributor Author

pannal commented Jul 6, 2018

This was broken due to a typo. Re-pushed.

@ruuk ruuk self-assigned this Jul 9, 2018
@ruuk
Copy link
Contributor

ruuk commented Jul 10, 2018

I only think wrapping lists make sense for long lists.

@pannal
Copy link
Contributor Author

pannal commented Jul 10, 2018

I disagree. Wrapping makes sense for any list with more than two items, that doesn't close by pressing UP.

Here's why: Navigating a UI daily in my case leads to me knowing the position of every control in every list. I know that "Go to TV Shows" is at the bottom of the three-dot-dropdown inside the episode window. I don't even have to think about that, press the three-dot-dropdown, up and OK and am where I want to be.

I don't see any reason why we wouldn't do this; also I'd strongly suggest not doing this for long lists only, because if the user detects wrapping in lists, he expects it in every list and gets annoyed otherwise.

Edit: This isn't exclusive to me, when using a remote to navigate, people develop a kind of UI-muscle-memory.

@pannal pannal force-pushed the pr_plsettings_roundrobin branch from 43a8bfd to 2619bbe Compare August 13, 2018 14:46
@pannal
Copy link
Contributor Author

pannal commented Aug 13, 2018

Rebased onto develop

@ruuk ruuk force-pushed the develop branch 2 times, most recently from 78f9acc to 126aaba Compare August 31, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants