-
Notifications
You must be signed in to change notification settings - Fork 126
Add vertical round robining for dialogs where it fits #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
66eb6b7
to
43a8bfd
Compare
This was broken due to a typo. Re-pushed. |
I only think wrapping lists make sense for long lists. |
I disagree. Wrapping makes sense for any list with more than two items, that doesn't close by pressing UP. Here's why: Navigating a UI daily in my case leads to me knowing the position of every control in every list. I know that "Go to TV Shows" is at the bottom of the three-dot-dropdown inside the episode window. I don't even have to think about that, press the three-dot-dropdown, up and OK and am where I want to be. I don't see any reason why we wouldn't do this; also I'd strongly suggest not doing this for long lists only, because if the user detects wrapping in lists, he expects it in every list and gets annoyed otherwise. Edit: This isn't exclusive to me, when using a remote to navigate, people develop a kind of UI-muscle-memory. |
43a8bfd
to
2619bbe
Compare
Rebased onto develop |
78f9acc
to
126aaba
Compare
GHI (If applicable): #
Description:
Add round robining on dialog(s) where it makes sense. Unify episodes view options dropdown behaviour by closing it on left instead of top.
Checklist: