Fix header tools so login and logout are not both shown after authent… - #162
Open
aryan7081 wants to merge 1 commit into
Open
Fix header tools so login and logout are not both shown after authent…#162aryan7081 wants to merge 1 commit into
aryan7081 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161
This issue happened because the development header tools in
packages/layout/slots/Tools.tsxalways rendered both/loginand/logoutand never read authentication state. The root loader already exposesisAuthenticated, but the tools slot ignored it, so both links stayed visible after a successful login.This fix reads
isAuthenticatedfrom the root loader and shows only Log in for anonymous visitors and only Log out for authenticated users. It keeps the links development-only, uses translated labels with English fallbacks, and adds a layout news fragment for the changelog.Caution
The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.