-
-
Notifications
You must be signed in to change notification settings - Fork 10
Reorganize templates structure #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Testing instructions: COOKIEPLONE_REPOSITORY_TAG=create-templates-folder uvx [email protected] |
davisagli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but with some reservations about the "monorepo" project name.
| "templates": { | ||
| "project": { | ||
| "path": "./project", | ||
| "path": "./templates/projects/monorepo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be to call this volto rather than monorepo. monorepo is a description of how it is organized, not what kind of project it creates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really clear what's the purpose of this directory. It looks like neither projects/volto nor projects/monorepo, but just project, based on its contents of a single project. Maybe I missed some earlier conversation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davisagli @ericof Steve and I been chatting today about naming of all the possible type of outputs that Cookieplone can generate. We tried to stablish a unified naming for them, mainly for documentation. For now, we settled on:
1 Plone site
It has both a frontend add-on and a backend add-on, and its purpose is to build a website. This was formerly called a project.
2 Package with frontend and backend add-ons
It has both a frontend add-on and a backend add-on that integrate with each other, and its purpose is to build a feature for release as a package.
3 Package with frontend add-on only
It has a frontend add-on only, and its purpose is to build a feature for release as a package.
4 Package with backend add-on only
It has a backend add-on only, and its purpose is to build a feature for release as a package.
What do you think?
I am planning to write a document about the "addon driven development" that we have now in Plone. It will include this and all what it entails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, I didn't see @sneridagh's comment, before creating a separate issue to discuss and expand upon it, at #191. Would it be better to carry the discussion of this topic to the issue, and give it better visibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer tackling that on an new issue
stevepiercy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much to add, but it looks good, with a couple of minor changes for Plone version support.
| "6.0.8", | ||
| "6.0.9", | ||
| "6.1.0a1", | ||
| "6.1.0a2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add versions recently released.
6.0.15 and 6.1.1 and their rc or a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericof the recent versions of the 6.0.x and 6.1.x lines are still missing.
Co-authored-by: Steve Piercy <[email protected]>
Fixes #186