Skip to content

Conversation

@ericof
Copy link
Member

@ericof ericof commented Mar 27, 2025

Fixes #186

@ericof ericof added the 04 type: enhancement making existing stuff better label Mar 27, 2025
@ericof ericof self-assigned this Mar 27, 2025
@ericof ericof marked this pull request as ready for review March 27, 2025 19:02
@ericof ericof requested a review from sneridagh as a code owner March 27, 2025 19:02
@ericof
Copy link
Member Author

ericof commented Mar 27, 2025

Testing instructions:

COOKIEPLONE_REPOSITORY_TAG=create-templates-folder uvx [email protected]

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but with some reservations about the "monorepo" project name.

"templates": {
"project": {
"path": "./project",
"path": "./templates/projects/monorepo",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be to call this volto rather than monorepo. monorepo is a description of how it is organized, not what kind of project it creates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really clear what's the purpose of this directory. It looks like neither projects/volto nor projects/monorepo, but just project, based on its contents of a single project. Maybe I missed some earlier conversation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davisagli @ericof Steve and I been chatting today about naming of all the possible type of outputs that Cookieplone can generate. We tried to stablish a unified naming for them, mainly for documentation. For now, we settled on:

1 Plone site
It has both a frontend add-on and a backend add-on, and its purpose is to build a website. This was formerly called a project.

2 Package with frontend and backend add-ons
It has both a frontend add-on and a backend add-on that integrate with each other, and its purpose is to build a feature for release as a package.

3 Package with frontend add-on only
It has a frontend add-on only, and its purpose is to build a feature for release as a package.

4 Package with backend add-on only
It has a backend add-on only, and its purpose is to build a feature for release as a package.

What do you think?

I am planning to write a document about the "addon driven development" that we have now in Plone. It will include this and all what it entails.

Copy link
Contributor

@stevepiercy stevepiercy Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I didn't see @sneridagh's comment, before creating a separate issue to discuss and expand upon it, at #191. Would it be better to carry the discussion of this topic to the issue, and give it better visibility?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer tackling that on an new issue

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to add, but it looks good, with a couple of minor changes for Plone version support.

"6.0.8",
"6.0.9",
"6.1.0a1",
"6.1.0a2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add versions recently released.

6.0.15 and 6.1.1 and their rc or a.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericof the recent versions of the 6.0.x and 6.1.x lines are still missing.

@ericof ericof merged commit 7b543ea into main Mar 31, 2025
32 checks passed
@ericof ericof deleted the create-templates-folder branch March 31, 2025 16:13
@github-project-automation github-project-automation bot moved this from In Progress to Done in Bucharest Sprint 2025 Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

04 type: enhancement making existing stuff better

Projects

Development

Successfully merging this pull request may close these issues.

Move templates to a /templates folder

5 participants