Skip to content

Conversation

@boss6825
Copy link
Member

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commit.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #121

@boss6825 boss6825 requested a review from ericof as a code owner December 18, 2025 20:10
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak to news.

CI checks are failing. Did you run tests locally? If not, check out this repo's readme for how to do so. See https://github.com/plone/cookieplone-templates?tab=readme-ov-file#run-tests. Then you can make sure things work and pass tests before pushing changes.

@wesleybl
Copy link
Member

Co-authored-by: Steve Piercy <[email protected]>
@stevepiercy
Copy link
Contributor

@boss6825 for an extra challenge, would you please take a look @wesleybl's comment #323 (comment) and attempt to address the failing CI checks? We don't merge PRs that don't pass all CI checks and tests. Thank you!

@wesleybl
Copy link
Member

@stevepiercy The fix has already been made, but @sneridagh needs to generate a release of Volto.

@boss6825
Copy link
Member Author

boss6825 commented Jan 1, 2026

@davisagli I have made the required changes ....

@davisagli davisagli merged commit ded7d9a into plone:main Jan 11, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Acceptance make commands not consistent

4 participants