Skip to content

fixes #104 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixes #104 #105

wants to merge 1 commit into from

Conversation

gil-cano
Copy link
Contributor

@gil-cano gil-cano commented May 2, 2025

Fix ruff format call.

@stevepiercy stevepiercy requested review from ericof and davisagli May 2, 2025 21:54
@stevepiercy stevepiercy linked an issue May 2, 2025 that may be closed by this pull request
Format codebase after code generation in backend_addon not working #104
Open
stevepiercy
stevepiercy approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get another technical review to make sure. Meanwhile, what is the console output after this change?

cookieplone/utils/formatters.py
for cmd in cmds:
subprocess.run(cmd, shell=True, capture_output=True) # noQA: S602
subprocess.run(cmd, capture_output=True, check=True) # noqa: S603
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, and appears to be more secure.

@gil-cano
Copy link
Contributor Author

gil-cano commented May 5, 2025

the console output after this change is:

==> Format codebase
Installed 1 package in 5ms
Found 1 error (1 fixed, 0 remaining).
Installed 1 package in 2ms
19 files left unchanged
Installed 6 packages in 53ms

@stevepiercy
Copy link
Contributor

@davisagli @ericof could I get a review on this one? Looks pretty quick and easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy approved these changes

@ericof ericof Awaiting requested review from ericof

@davisagli davisagli Awaiting requested review from davisagli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format codebase after code generation in backend_addon not working
2 participants
@gil-cano @stevepiercy