Fixes #62 #63
Merged
Fixes #62 #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add exception per #62
davisagli
reviewed
Feb 4, 2025
| except FileNotFoundError: | ||
| raw_version = "" | ||
| except PermissionError: | ||
| raw_version = "" |
Member
There was a problem hiding this comment.
This is fine, but you could also change line 19 to except (FileNotFoundError, PermissionError):
Member
|
@ewohnlich Thanks. CHANGES.md is updated automatically at release time from the towncrier entries in the news folder. See https://6.docs.plone.org/contributing/index.html#change-log-entry |
davisagli
approved these changes
Feb 4, 2025
Member
|
@ewohnlich I edited the PR description to say "fixes #62" so that the issue will get automatically closed when I merge. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
What's your change log policy here, do you want me to edit CHANGES.md?