-
-
Notifications
You must be signed in to change notification settings - Fork 4
Fix regression in generating namespace packages #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ericof I tried to make a release with this by running |
|
Are we not using zest.releaser to make releases? It's saved me from making mistakes several times, especially with |
|
@stevepiercy The make release command is using zest.releaser. It seems check-manifest is a bit overeager here because the files it says are missing are files that should not actually be in the sdist. |
|
I don't think it makes sense to use check-manifest with a project that is using hatchling as its build-system, because hatchling uses configuration in pyproject.toml instead of MANIFEST.in |
|
I skipped the check-manifest check and uploaded the 0.9.2 release |
|
Makes sense. You can continue and ignore the manifest warning. AFAIK, zest.releaser doesn't check pyproject.toml |
|
jinx! |
|
I was coming here to say check-manifest does not know how to handle |
Fixes #80