-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds docs for creating custom control panel #1909
base: 6.0
Are you sure you want to change the base?
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
…nsha0-control-panel
- Sentence case headings - Add content to empty headings - Use appropriate list type, either bulleted or definition - Indent lists 4 spaces for consistency and visually spotting syntax issues - Use `{file}` markup for files, directories, and file paths - Emphasize lines in code block as needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completed my review by making thoroughly commented commits.
I have a couple of questions for clarification.
This also needs a technical peer review before getting merged.
Thank you for pulling all the pieces together. This is awesome.
``` | ||
|
||
|
||
## Register a control panel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a little bit lost here. Does this heading apply to both the plonecli and manual options, or just the manual one?
- If both, then we should add a sentence to clarify this.
- If only the latter, then its heading level should increase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the Plone site need to be restarted after adding all the files for the control panel to show up? If so, then that step also needs to be documented in the appropriate location.
@plone/classicui-team can I get a review from y'all? This will establish the basis for both Classic UI and Volto. |
@sneridagh I couldn't find an example of how to create a control panel in Volto. Does a clear how to guide exist anywhere? We should include that in this page, or if it exists, add a link to that resource. |
-> https://training.plone.org/mastering-plone/registry.html#add-a-custom-control-panel |
@rohnsha0 would you please adapt and add that content to this PR? Then developers can go to a single page to add a control panel, regardless of frontend. FTW! |
Fixes #4131
Fixes #1304
See #1882
📚 Documentation preview 📚: https://plone6--1909.org.readthedocs.build/