fix(pat-tinymce): Add a fallback for Plone 5 images without data-pict… - #1493
Closed
thet wants to merge 1 commit into
Closed
fix(pat-tinymce): Add a fallback for Plone 5 images without data-pict…#1493thet wants to merge 1 commit into
thet wants to merge 1 commit into
Conversation
…urevariant attributes. Responsive picture variants were introduced in Plone 6. Content from Plone 5 where no `data-picturevariant` was available lost had no scale selected in the image dialog. This PR fixes that by falling back to the `data-scale` attribute. This allows old images in the TinyMCE image edit dialog to have their scale preselected. The precondition for this is that the old scales are configured as picture variants.
thet
force-pushed
the
tinymce-scale-fallback
branch
from
August 18, 2025 17:03
ca989e7 to
3e845b9
Compare
thet
marked this pull request as draft
September 11, 2025 09:35
Member
Author
|
I used an upgrade step using collective.exportimport.fix_html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…urevariant attributes.
Responsive picture variants were introduced in Plone 6. Content from Plone 5 where no
data-picturevariantwas available lost had no scale selected in the image dialog.This PR fixes that by falling back to the
data-scaleattribute. This allows old images in the TinyMCE image edit dialog to have their scale preselected. The precondition for this is that the old scales are configured as picture variants.I tried my best to test this feature but had to give up.
TinyMCE is untestable.