Skip to content

tinymce langs 8 #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thet wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

tinymce langs 8 #1558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
835db36
fix(pat-tinymce): Ingore english language variant translations.
thet Oct 9, 2025
87e5498
Away from ignore variants to refactoring this method for use with the…
thet Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 29 additions & 15 deletions src/pat/tinymce/tinymce--implementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,29 +296,43 @@

async initLanguage() {
const i18n = new I18n();
let lang = i18n.currentLanguage;
const lang_parts = i18n.currentLanguage.split("-");

// Fix for country specific languages
if (lang.split("-").length > 1) {
lang = lang.split("-")[0] + "_" + lang.split("-")[1].toUpperCase();
}
// Country specific languages in TinyMCE 8 in in the form: `lang-COUNTRY_CODE`
let lang =
lang_parts.length === 1
? lang_parts[0]
: `${lang_parts[0]}-${lang_parts[1].toUpperCase()}`;

debugger;

Check warning on line 307 in src/pat/tinymce/tinymce--implementation.js

View workflow job for this annotation

GitHub Actions / test 

Unexpected 'debugger' statement
if (lang !== "en") {
// load translations from tinymce-i18n
try {
await import(`tinymce-i18n/langs7/${lang}`);
await import(`tinymce-i18n/langs8/${lang}.js`);
} catch {
log.debug("Could not load TinyMCE language: ", lang);
try {
// expected lang not available, let's fallback to closest one
if (lang.split("_").length > 1) {
lang = lang.split("_")[0];
} else {
lang = lang + "_" + lang.toUpperCase();
}
log.debug("Trying with: ", lang);
await import(`tinymce-i18n/langs7/${lang}`);
log.debug("Could not load TinyMCE language: ", lang);

lang = lang_parts[0];
log.debug("Fall back to: ", lang);

await import(`tinymce-i18n/langs8/${lang}.js`);
} catch {
try {
log.debug("Could not load TinyMCE language: ", lang);

// Some languages have the form of `lang-LANG`, etc. `fr-FR`.
lang = `${lang_parts[0]}-${lang_parts[0].toUpperCase()}`;
log.debug("Fall back to: ", lang);

await import(`tinymce-i18n/langs8/${lang}.js`);
} catch {
log.debug(
"Could not load TinyMCE language. Fallback to English",
);
lang = "en";
}

log.debug("Could not load TinyMCE language. Fallback to English");
lang = "en";
}
Expand Down
Loading