fix(modal): title extraction method (jquery removed .context) - #1606
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime error in the modal pattern’s image-modal path by removing reliance on the deprecated/removed jQuery .context property when extracting the modal title.
Changes:
- Replace
self.$el.context.innerTexttitle extraction withself.$el.text()to avoidcontext is undefinederrors forimage: true.
Comments suppressed due to low confidence (1)
src/pat/modal/modal.js:660
title,src, andsrcsetare concatenated into an HTML string. If any of these values contain characters like<or quotes (e.g., via encoded text or programmatically-set attributes), this can result in HTML injection. Prefer constructing the DOM with jQuery and setting text/attributes via.text()/.attr()to ensure proper escaping.
var title = $.trim(self.$el.text()) || "Image";
// XXX aria?
self.$raw = $(
"<div><h1>" +
title +
'</h1><div id="content"><div class="modal-image"><img src="' +
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var src = self.$el.attr("href"); | ||
| var srcset = self.$el.attr("data-modal-srcset") || ""; | ||
| var title = $.trim(self.$el.context.innerText) || "Image"; | ||
| var title = $.trim(self.$el.text()) || "Image"; |
Member
|
@Gomez would be great if you could cherry pick this commit and create a second PR based on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
JSError: Uncaught TypeError: can't access property "innerText", e.$el.context is undefinedifdata-pat-plone-modal="image: true"