Skip to content

Conversation

@frapell
Copy link
Member

@frapell frapell commented Nov 12, 2025

@petschki So, apparently the fix I did here was lost because around that time it was the ES6 rewrite happening...

@petschki @thet If you guys could take a quick look :)

For master I submitted another PR #656

@petschki petschki force-pushed the frapell-3.1.x-fix-486 branch from ff17b13 to d76b47f Compare November 12, 2025 22:43
petschki
petschki previously approved these changes Nov 12, 2025
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same simplification like in #656 ... good to merge

@petschki petschki force-pushed the frapell-3.1.x-fix-486 branch from d76b47f to f13a4b5 Compare November 13, 2025 10:45
@thet thet marked this pull request as draft November 13, 2025 14:26
package.json Outdated
"@patternslib/patternslib": "*",
"@plone/mockup": "*"
"@patternslib/patternslib": "9.10.3",
"@plone/mockup": "5.4.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mosaic 3.1.x is for Plone 6.0.x / staticresources 2.1.x so mockup should stay on 5.1.x ... this is all because of the pat-contentbrowserpattern which was introduced in mockup 5.2.x

@petschki
Copy link
Member

@thet I'll revert your version updates here and align it to Plone 6.0 pins as mentioned above ... currently I cannot debug anything due to the sass warnings ...

@petschki petschki self-requested a review November 14, 2025 21:34
@petschki petschki dismissed their stale review November 14, 2025 21:34

new changes

@frapell
Copy link
Member Author

frapell commented Nov 16, 2025

@petschki @thet I've tested with latest changes, and this still doesn't address the issue #486

You can test this by simply adding a RichText tile, then using the code tinymce plugin and enter this

<p>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.min.js" type="text/javascript"></script>
</p>

After saving, and then saving the Mosaic, if you inspect the HTML you will see

<p>
<script data-mce-src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.min.js" src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.min.js" type="mce-text/javascript"></script>
</p>

All of those mce added are used by TinyMCE internally and the tile should not be saved like that.

@petschki petschki force-pushed the frapell-3.1.x-fix-486 branch from 3e1d079 to 062330c Compare November 17, 2025 09:43
@petschki
Copy link
Member

@thet I've reverted the dependency version updates for now and my code improvement since it didn't worked reliable on 3.1.x

@frapell your initial fix is working for me now and I will not put any effort in code cleanup/refactorings for 3.1.x anymore. when you can confirm, I'll merge this.

@petschki petschki marked this pull request as ready for review November 17, 2025 09:47
@frapell
Copy link
Member Author

frapell commented Nov 17, 2025

@petschki Yup, this is now working fine for me... I think it can be merged (And if we can get a new 3.1.x release, that would be great :) )

FYI, I tried yarn install and yarn build and I still get differences, and the feature continue to work the same, so no idea what's going on there 🤷

@petschki
Copy link
Member

I'll come up with some dependency version updates and pins for Plone 6.0 in a separate PR ... I'll merge this meanwhile

@petschki petschki merged commit 8158ab6 into 3.1.x Nov 17, 2025
8 of 12 checks passed
@petschki petschki deleted the frapell-3.1.x-fix-486 branch November 17, 2025 10:54
@petschki
Copy link
Member

I've released 3.1.6 with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants