-
-
Notifications
You must be signed in to change notification settings - Fork 26
Bugfix 3.1.x: Use TinyMCE getContent() to get editor contents on save #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ff17b13 to
d76b47f
Compare
petschki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same simplification like in #656 ... good to merge
d76b47f to
f13a4b5
Compare
package.json
Outdated
| "@patternslib/patternslib": "*", | ||
| "@plone/mockup": "*" | ||
| "@patternslib/patternslib": "9.10.3", | ||
| "@plone/mockup": "5.4.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mosaic 3.1.x is for Plone 6.0.x / staticresources 2.1.x so mockup should stay on 5.1.x ... this is all because of the pat-contentbrowserpattern which was introduced in mockup 5.2.x
|
@thet I'll revert your version updates here and align it to Plone 6.0 pins as mentioned above ... currently I cannot debug anything due to the sass warnings ... |
|
@petschki @thet I've tested with latest changes, and this still doesn't address the issue #486 You can test this by simply adding a RichText tile, then using the After saving, and then saving the Mosaic, if you inspect the HTML you will see All of those |
3e1d079 to
062330c
Compare
|
@petschki Yup, this is now working fine for me... I think it can be merged (And if we can get a new 3.1.x release, that would be great :) ) FYI, I tried |
|
I'll come up with some dependency version updates and pins for Plone 6.0 in a separate PR ... I'll merge this meanwhile |
|
I've released |
@petschki So, apparently the fix I did here was lost because around that time it was the ES6 rewrite happening...
@petschki @thet If you guys could take a quick look :)
For
masterI submitted another PR #656