Skip to content

Conversation

@petschki
Copy link
Member

added sass==1.77.8 resolution to fix deprecation warnings. no changes when compiling.

@petschki petschki marked this pull request as ready for review November 17, 2025 13:06
@petschki
Copy link
Member Author

@thet @frapell would be interesting if you get changes when you do yarn install && yarn compile in this branch ...

@frapell
Copy link
Member

frapell commented Nov 17, 2025

@petschki I only get it for the remote file

frapell@lorraine:/trabajo/plone/buildout.coredev/src/plone.app.mosaic$ git pull
remote: Enumerating objects: 124, done.
remote: Counting objects: 100% (123/123), done.
remote: Compressing objects: 100% (61/61), done.
remote: Total 124 (delta 68), reused 110 (delta 58), pack-reused 1 (from 1)
Receiving objects: 100% (124/124), 727.42 KiB | 1.99 MiB/s, done.
Resolving deltas: 100% (68/68), completed with 35 local objects.
From github.com:plone/plone.app.mosaic
   ba62fe85..5543b489  3.1.x                        -> origin/3.1.x
 * [new branch]        3.1.x-dependency-maintenance -> origin/3.1.x-dependency-maintenance
 * [new branch]        dependency-maintenance       -> origin/dependency-maintenance
   26b170ee..7a106316  master                       -> origin/master
Your configuration specifies to merge with the ref 'refs/heads/frapell-master-fix-486'
from the remote, but no such ref was fetched.
frapell@lorraine:/trabajo/plone/buildout.coredev/src/plone.app.mosaic$ git checkout dependency-maintenance 
branch 'dependency-maintenance' set up to track 'origin/dependency-maintenance'.
Switched to a new branch 'dependency-maintenance'
frapell@lorraine:/trabajo/plone/buildout.coredev/src/plone.app.mosaic$ git status
On branch dependency-maintenance
Your branch is up to date with 'origin/dependency-maintenance'.

nothing to commit, working tree clean
frapell@lorraine:/trabajo/plone/buildout.coredev/src/plone.app.mosaic$ yarn install
yarn install v1.22.22
[1/5] Validating package.json...
[2/5] Resolving packages...
warning Resolution field "[email protected]" is incompatible with requested version "sass@^1.87.0"
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning "@patternslib/patternslib > @fullcalendar/[email protected]" has incorrect peer dependency "luxon@^2.0.0".
warning "@plone/mockup > @plone/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0".
warning " > [email protected]" has unmet peer dependency "@popperjs/core@^2.11.8".
warning "@plone/mockup > @11ty/eleventy-upgrade-help > [email protected]" has unmet peer dependency "posthtml@^0.16.6".
warning "@patternslib/dev > @release-it/[email protected]" has incorrect peer dependency "release-it@^17.0.0".
warning "@patternslib/dev > @commitlint/cli > @commitlint/load > [email protected]" has unmet peer dependency "@types/node@*".
warning "@patternslib/dev > @commitlint/cli > @commitlint/load > [email protected]" has unmet peer dependency "typescript@>=5".
[5/5] Building fresh packages...
Done in 2.99s.
frapell@lorraine:/trabajo/plone/buildout.coredev/src/plone.app.mosaic$ yarn build
yarn run v1.22.22
$ npm-run-all build:webpack build:css
$ NODE_ENV=production webpack --config webpack.config.js
assets by status 2.09 MiB [cached] 2091 assets
assets by path . 134 KiB
  asset plone-mosaic-remote.min.js 67.2 KiB [emitted] [minimized] (name: __patternslib_mf__plonemosaic) 1 related asset
  asset plone-mosaic.min.js 66.6 KiB [compared for emit] [minimized] (name: plone-mosaic.min) 1 related asset
orphan modules 132 KiB [orphan] 173 modules
runtime modules 165 KiB 28 modules
modules by path ./node_modules/bootstrap-icons/icons/*.svg 1.21 MiB
  ./node_modules/bootstrap-icons/icons/0-circle-fill.svg 488 bytes [optional] [built] [code generated]
  + 2077 modules
javascript modules 802 KiB 34 modules
provide-module modules 126 bytes
  provide shared module (default) [email protected] = ./node_modules/jquery-form/d...(truncated) 42 bytes [built] [code generated]
  + 2 modules
consume-shared-module modules 126 bytes
  consume shared module (default) jquery@^3.7.1 (singleton) (fallback: ./node_modu...(truncated) 42 bytes [built] [code generated]
  consume shared module (default) underscore@^1.13.7 (singleton) (fallback: ./node...(truncated) 42 bytes [built] [code generated]
  consume shared module (default) jquery-form@=4.3.0 (singleton) (fallback: ./node...(truncated) 42 bytes [built] [code generated]
./node_modules/@plone/mockup/src/iconmap.json 163 KiB [optional] [built] [code generated]
data:image/svg+xml;utf8,<svg xmlns="http.. 1.96 KiB [built] [code generated]
webpack 5.102.1 compiled successfully in 3639 ms
$ npm-run-all css-compile css-minify
$ sass --load-path=node_modules --style expanded --source-map --embed-sources --no-error-css resources/scss/mosaic.scss:src/plone/app/mosaic/browser/static/mosaic.css
$ cleancss -O1 --format breakWith=lf --with-rebase --source-map --source-map-inline-sources --output src/plone/app/mosaic/browser/static/mosaic.min.css src/plone/app/mosaic/browser/static/mosaic.css
Done in 4.83s.
frapell@lorraine:/trabajo/plone/buildout.coredev/src/plone.app.mosaic$ git status
On branch dependency-maintenance
Your branch is up to date with 'origin/dependency-maintenance'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   src/plone/app/mosaic/browser/static/plone-mosaic-remote.min.js
        modified:   src/plone/app/mosaic/browser/static/plone-mosaic-remote.min.js.map

no changes added to commit (use "git add" and/or "git commit -a")

@petschki
Copy link
Member Author

whats the output of git diff --color-words=. src/plone/app/mosaic/browser/static/plone-mosaic-remote.min.js ?

@frapell
Copy link
Member

frapell commented Nov 17, 2025

@petschki Only diff appears to be at the beginning

image

and the end

image

🤔 🤔

@petschki
Copy link
Member Author

that's the strange ID recalculation which I've also mentioned on discord last week. I do not know, how these IDs are calculated but there seems to be differences depending on the platform ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants