Skip to content

feat: plantinum sponsor logo changes#246

Merged
erral merged 4 commits intomainfrom
platinum-sponsorts
Mar 12, 2026
Merged

feat: plantinum sponsor logo changes#246
erral merged 4 commits intomainfrom
platinum-sponsorts

Conversation

@erral
Copy link
Member

@erral erral commented Mar 5, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

These are the changes:

  • Smaller logo (thumb scale)
  • Change headline and add text before the platinum logos
  • Add an empty logo to call future sponsors

This should be the appearance. It requires the platinum sponsor logo to have a transparent background (which my demo logos have not)

2026-03-05 21-31-20

@erral erral requested review from Fosten and fredvd March 5, 2026 20:37
@erral
Copy link
Member Author

erral commented Mar 5, 2026

cc: @astridjuizi

@stevepiercy
Copy link
Contributor

I think surrounding "YOUR LOGO HERE" with a dotted or dashed border would give the impression that it's both a button and something they need to complete.

Also I think only one instance is enough.

@erral
Copy link
Member Author

erral commented Mar 7, 2026

What about something like this?

2026-03-07 12-04-52

@stevepiercy
Copy link
Contributor

Yes!

@erral
Copy link
Member Author

erral commented Mar 11, 2026

@stevepiercy can you approve the PR, let's see how it is shown in testing.plone.org and get Marketing's approval

@Fosten
Copy link
Contributor

Fosten commented Mar 11, 2026

Thank you @erral !

It's a nice improvement on the previous version.
And I like the slight background-color change.

Is Your Logo Here a clickable link?
If there's only one Platinum Sponsor, it does provide visual balance for now, but not sure it's necessary long-term.

Suggestions:

  • “shapes our future/shape the future" used twice.
  • “them” sounded weird in my head. “You too can help shape the future of freedom!” but probably fine either way.

I would say let's deploy it, so we can improve the production layout, with a mind towards future adjustments.

@astridjuizi and @rioksane can you also take a look?

Copy link
Contributor

@Fosten Fosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. General suggestions at #246 (comment)

@erral
Copy link
Member Author

erral commented Mar 11, 2026

Yes the logo is clickable to the sponsor page and the put here your logo is clickable to the sponsorship page.

I want to put this on testing, take a screenshot and share it here so that we can discuss it further if needed

@erral erral merged commit e9173fb into main Mar 12, 2026
13 checks passed
@erral erral deleted the platinum-sponsorts branch March 12, 2026 07:08
@astridjuizi
Copy link

Tiny text suggestion: "Join in shaping the future of digital freedom"

Avoids "them" which has a them/us feeling, and has even more momentum and feels even more inviting than "You too can help shape the future of freedom!”

@erral
Copy link
Member Author

erral commented Mar 12, 2026

I attach 3 files:

  • Home page
  • Why Plone? page
  • A sponsor page

I think that the 3rd one looks a bit strange, we don't have that much content, and the footer goes all the way up... I don't know... What do you think?

Those with access to testing.plone.org can check it live.

HOME
testing plone org_

WHAT IS PLONE

testing plone org_why-plone_what-is-plone

SPONSOR PAGE

testing plone org_foundation_sponsorship_sponsors_codesyntax

@astridjuizi
Copy link

How about a chunk of white space between the page and the footer? The footer feels too close on all three examples

@erral erral mentioned this pull request Mar 16, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants