Handle animated WebP images #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
gforcada
force-pushed
the
animated-webp-images
branch
from
b6bd0c5 to
7fc8d38
Compare
davisagli
requested changes
Oct 8, 2025
gforcada
force-pushed
the
animated-webp-images
branch
from
7fc8d38 to
997f094
Compare
davisagli
approved these changes
Oct 9, 2025
Member
|
@jenkins-plone-org please run jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124
WebP support already existed, but it did not handle the cases of animated WebP images, they are scaled to a single still image 😕
Warning
the minimal approach I took is to handle WebP, always like a gif image, as there is already some code to handle the case of a single frame (i.e. WebP/gif images that have no animation).
If we want to handle the cases differently, I can update the code