Skip to content

Conversation

@cekk
Copy link
Member

@cekk cekk commented May 23, 2022

No description provided.

@mister-roboto
Copy link

@cekk thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@cekk
Copy link
Member Author

cekk commented May 23, 2022

@sneridagh @ericof any ideas about why Plone6 tests fails?

@cekk cekk requested a review from sneridagh May 23, 2022 13:18
@pbauer
Copy link
Member

pbauer commented May 23, 2022

Weird. Maybe add a check with getattr(obj, "_v__providedBy__", None) before deleting the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants