Skip to content

Conversation

@jaroel
Copy link
Member

@jaroel jaroel commented May 16, 2023

No description provided.

@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 924ae39
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6466893639899c0008dc2b06

@cypress
Copy link

cypress bot commented May 16, 2023

Passing run #5195 ↗︎

0 493 20 0 Flakiness 0

Details:

Merge branch 'master' into numberOfFolderishDocuments
Project: Volto Commit: 924ae39ce8
Status: Passed Duration: 12:23 💡
Started: May 18, 2023 8:26 PM Ended: May 18, 2023 8:39 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jaroel jaroel marked this pull request as ready for review May 16, 2023 16:25
@jaroel jaroel requested a review from robgietema May 16, 2023 16:25
@jaroel
Copy link
Member Author

jaroel commented May 16, 2023

Depends on/blocked by plone/plone.volto#118

@jaroel jaroel marked this pull request as draft May 18, 2023 20:23
@jaroel
Copy link
Member Author

jaroel commented May 18, 2023

UX review feedback will be provided and we'll use that instead of this Folder icon.

@davisagli
Copy link
Member

@sneridagh @albertcasado What was the conclusion at the sprint about what icon to use here?

@sneridagh sneridagh added this to the Plone 6.1 milestone Jun 6, 2023
@sneridagh sneridagh modified the milestones: Plone 6.1, 18.x.x Nov 4, 2023
@sneridagh sneridagh modified the milestones: 18.x.x, 19.x.x May 21, 2024
@pnicolli
Copy link
Contributor

@davisagli did you have any news about this eventually? Do you think this could go in Volto 19?

@davisagli
Copy link
Member

@pnicolli See related discussion in plone/plone.volto#118. We need to make sure it doesn't hurt performance, and I didn't make time to take a close look at it yet. I'd like to see it happen, but I don't think it will be ready for 6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs discussion

Development

Successfully merging this pull request may close these issues.

5 participants