Header slots - #7550
Conversation
|
@sneridagh were the anontools, search widget and site actions slots supposed to be sub-slots of the header tools (with the same slot id) or is it fine to have them as individual slots? Also, I'm not sure if I should've used CSS modules or not, I just followed the way it was done in the Header component. |
…73-seven-header-slots
Documentation build overview
214 files changed ·
|
# Conflicts: # packages/layout/slots/Tools.tsx
The idea always was to model what we had back in the day with viewlets and viewlets managers, and the idea that you can nest them. The do not have to share the name or id, but they are meant to be semantic in the naming. So we have zones in the header (and in other slots) that we named back in the day, but we can name them now. Take a look at the classic viewlet managers to get the point: https://classic.demo.plone.org/en/manage-viewlets 
As long as they cover the "areas" left (logo), center (sections, menu) then right (actions, search widget, anontools language switcher?), is enough, because all are extensible and layered (stackable) by default. So we are good. |
| }); | ||
|
|
||
| config.registerSlotComponent({ | ||
| name: 'Tools', |
There was a problem hiding this comment.
Not sure about calling hem all Tools. The name of the slot component should be different... at least how I see it.
| /> | ||
| <SlotRenderer | ||
| name="language-switcher" | ||
| name="headerTools" |
There was a problem hiding this comment.
I'm ok on doing this, and move it inside the tools.
# Conflicts: # packages/layout/locales/de/common.json
|
Important Hello! Thanks for contributing to Plone Aurora! FYI, since June 5th, Plone Aurora lives in its own repository, thus, the |
5 participants
Closes plone/aurora#59