Skip to content

Conversation

@Manik-Khajuria-5
Copy link
Contributor

@Manik-Khajuria-5 Manik-Khajuria-5 commented Dec 17, 2025


Issue number

Contributes to #4460


Description

This PR refactors the History component located at
packages/volto/src/components/manage/History/History.jsx by converting it from a legacy class-based React component to a modern hook-based functional component.


Key Changes

  • Converted the History component from a class-based implementation to a functional component
  • Replaced lifecycle methods with appropriate React hooks (useEffect, useCallback, useState)
  • Preserved existing async data fetching using asyncConnect
  • Maintained Redux integration via connect and compose
  • Ensured correct handling of history entries processing and revert actions
  • Retained portal-based toolbar rendering logic with client-side checks
  • Kept full feature and behavior parity with the previous implementation


@Manik-Khajuria-5 Manik-Khajuria-5 marked this pull request as ready for review December 17, 2025 14:03
@sneridagh
Copy link
Member

sneridagh commented Dec 17, 2025

@Manik-Khajuria-5 Could you please stop flooding our CI actions? Are these PRs AI-generated?

@Manik-Khajuria-5
Copy link
Contributor Author

Sorry, this was an honest mistake and it won’t happen again.
These PRs are not AI-generated; I’ve written and reviewed the changes myself.

@sneridagh
Copy link
Member

@Manik-Khajuria-5 ok, no worries. It seemed to me that they were opened in a row in a very short interval. The team will take a look, however the issue is not a priority in the last months, could be that it took some time before the team can review them. On the other hand, thanks for your contribution. BTW, you don't need to close them, you can reopen this one.

@Manik-Khajuria-5 Manik-Khajuria-5 marked this pull request as draft December 18, 2025 01:11
@Manik-Khajuria-5 Manik-Khajuria-5 marked this pull request as ready for review December 18, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants