Skip to content

Conversation

@antcybersec
Copy link

@antcybersec antcybersec commented Dec 20, 2025

Fixes #7708

I've addressed the issue where viewableInBrowserObjects wasn't working for links inside Slate text blocks. It turns out the link renderer was bypassing the configuration check completely. I updated the ViewLink component in volto-slate to correctly check if the user is anonymous and if the configuration allows files to be viewed in the browser. If so, it now sets the URL to @@display-file, so it opens properly instead of forcing a download.

While I was at it, I also fixed a build error I hit on Windows with pnpm. The webpack LESS configuration wasn't finding semantic-ui-less because it was looking for hardcoded paths that didn't match the pnpm symlinks on Windows. I updated it to use require.resolve and better regexes so the build works reliably across different setups.


Closes #7708

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 20, 2025

Caution

The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, read
Plone's Code of Conduct,
Contributing to Plone,
First-time contributors, and
Contributing to Volto,
as this will greatly help the review process.

Welcome to the Plone community! 🎉

@mister-roboto
Copy link

@antcybersec you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have already signed the agreement, please allow a week for your agreement to be processed.
Once it is processed, you will receive an email invitation to join the plone GitHub organization as a Contributor.

If after a week you have not received an invitation, then please contact [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

viewableInBrowserObjects configuration not working for links in text blocks

2 participants