Fix random failure in test cypress blocks-table.js - #8326
Closed
wesleybl wants to merge 2 commits into
Closed
Conversation
Added `{ timeout: 15000 }` to all view-mode assertions after save.
Contributor
|
@wesleybl I had this problem and fixed it in my last PR https://github.com/plone/volto/pull/8321/changes. It was because the CI here runs headless and the test was too fast. When the test tried to select the first cell, it accidentally glitched out due to a Slate behavior and exited the table without writing the text. If you want to bring the change over here to keep it separate, we can do that, and then I will pull it into my branch as soon as we merge. |
Contributor
|
and our solutions are different, btw: #8321. |
Member
Author
|
@Wagner3UB Your solution is more complete. Could you please submit a PR to move it to the main branch? I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
{ timeout: 15000 }to all view-mode assertions after save.Fix error:
See: https://github.com/plone/volto/actions/runs/27320633041/job/80710719698?pr=8325#step:4:714