test(e2e): de-flake the project switcher assertion#12
Merged
Conversation
Under full-suite load the switcher assertions could read #project-select before navigation (or the focus refetch) settled it, since phase 1 dropped the old #doc-title settling wait. Assert the value by waiting for it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnrgu8jdLx12jkWY1B8vb3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #11. Under full-suite load, the
projects: the sidebar is scoped…e2e test could read#project-selectbefore navigation (or the new focus refetch) had settled the value, because phase 1 removed the old#doc-titlesettling wait that used to mask the race. This makes the switcher assertions wait for the value viapage.waitForFunctioninstead of reading a single racy snapshot — the product behavior is unchanged; only the test's observation is made deterministic.bun testis green across two consecutive full runs (156 tests, 9 files).🤖 Generated with Claude Code
https://claude.ai/code/session_01Gnrgu8jdLx12jkWY1B8vb3