Component Generation #16

plt-joey · 2021-06-29T18:34:33Z

Create a separate project publishable as a dotnet tool for component generation.

Update 2021-07-01: Added samples for generation via string manipulation and generation via AST

Update 2021-08-20: Code complete and ready for first-pass reviews

NOTES TO REVIEWERS:

I made minor changes to Dash.NET itself that the generated components require to function. If you are testing a generated component in a dash app you have to point it at the version of Dash.NET in this PR, and not the one on nuget
For that same reason I have not added anything to the build scripts for publishing this tool yet, the updated version of Dash.NET has to be published first
Using the generated components also requires a minor change to the dash app template (!2), contentRoot needs to point to the build output, and not to the source code:

let contentRoot = Reflection.Assembly.GetExecutingAssembly().Location |> Path.GetDirectoryName

Rough todo list, in no particular order

kunjee17 · 2021-09-07T15:54:53Z

Looks good to me.

src/Dash.NET/DashApp.fs

…ent generation

…oved old method

…onent generation

…nversion of ArrayOf and ObjectOf properties in component generation

…ons bug fix

…t generation

…e, some characters caused XML documentation to be invalid, '+' is not a valid character in DU case names

…ration

…nt generation

…ases

…erated components

…tion, was causing more issues than it solved

…o type.convert in component generation

… types

…ml components

alexcjohnson · 2021-09-10T12:42:12Z

src/Dash.NET.ComponentGeneration/DocumentationGeneration.fs

+    | ObjectOf (_, Some value) -> 
+        value
+        |> getTypePropDocumentation
+        |> Option.map (sprintf "dict with values of type: %s")


dict -> record?

(apologies for the late comment, just poking around here to see how you implemented things)

not in this case. ObjectOf is actually a Map, which is the F# version of IDictionary. I think I put dict here to be consistent with the python generator, but this technically should be Map.

Got it - just wanted to make sure this wasn't an unintended remnant from Python :)

kMutagene mentioned this pull request Jul 6, 2021

Adapt Feliz style DSL for Dash components #18

Closed

plt-joey changed the title ~~WIP: Component Generation~~ Component Generation Aug 20, 2021

This comment has been minimized.

Sign in to view

plt-joey marked this pull request as ready for review August 20, 2021 17:11

plt-joey mentioned this pull request Aug 20, 2021

Content root in build folder plotly/Dash.NET.Template#2

Open

This comment has been minimized.

Sign in to view

plt-joey force-pushed the component-generation branch from 664f2bb to c35618f Compare August 24, 2021 13:11

This comment has been minimized.

Sign in to view

jackparmer requested a review from kMutagene September 3, 2021 16:54

kaashyapan mentioned this pull request Sep 4, 2021

Dash Core components auto generate #14

Open

plt-joey commented Sep 7, 2021

View reviewed changes

src/Dash.NET/DashApp.fs Outdated Show resolved Hide resolved

plt-joey added 13 commits September 7, 2021 15:33

Created ComponentGeneration project from BackboneGenerator.fsx

51a1466

Added basic property generation to component generation

af2d65c

Added sample component generation via AST

a778627

Added basic component generation via AST, removed string-based compon…

2544ab2

…ent generation

added basic project generation

09d8cad

Added a method for loading component javascript files

25f6065

Uncomplicated method for loading component javascript files

0ce1e74

Created alternate method of loading component scripts on startup, rem…

49c4b41

…oved old method

Added project generation and building

d8b1bfe

Cleaned up AST generation, Added AST documentation

36d7581

metadata.json parsing and automatic property type generation for comp…

e9c0963

…onent generation

Added documentation generation to component generation, fixed json co…

42d65e4

…nversion of ArrayOf and ObjectOf properties in component generation

Improved component generation CLI

29f648e

plt-joey added 25 commits September 7, 2021 15:34

Added much better logging support to component generation

072b668

Component genration unrepresentable properties showing in F# definiti…

a0c4c4f

…ons bug fix

Various fixes and polishing to component generation

e0ea4fd

Added dotnet tool definition to component generation

9187b9d

Added usage documentation to component generation

520fcad

Misc cleanup to component generation

99a34a9

Fix AST generation using the wrong serialization function in componen…

74a0875

…t generation

Fixes to component generation: type list option would fail to generat…

6f04f68

…e, some characters caused XML documentation to be invalid, '+' is not a valid character in DU case names

Added pascal case conversion to type and case named in component gene…

1fcf8cc

…ration

Better naming for union cases, better handling of objectOf in compone…

7d24e89

…nt generation

Better type naming for component generation

fee8952

Component generation bug fixes, adding feliz constructors for union c…

a6c955a

…ases

Remove jebrains rider working folder

9059b44

Use camelCase in generated feliz-style helper constructors

f16ed24

Fix ObjectOf definition in component generation

ab686e0

Use a boxed serializable object conversion instead of ToString in gen…

a3f56d8

…erated components

Added conver to ObjectOf property in component generation

e95e0e9

component generation ObjectOf conversion bug fix

88b5fe8

Convert & to & in documentation of generated components

7c28893

Change all convert functions to be boxed in generated components

d901883

Remove optional types from shape/exact/flowobject in component genera…

99f9f6e

…tion, was causing more issues than it solved

Switch Dictionary to Map in component generation, switch .Convert() t…

925454a

…o type.convert in component generation

Fixed types passed into init and applyMembers for generated component…

cefa5af

… types

Fix component generation unit tests on linux

3764c45

Moved component assembly inspection to DashApp.run

afaf467

plt-joey force-pushed the component-generation branch from a5ea70b to afaf467 Compare September 7, 2021 19:43

This comment has been minimized.

Sign in to view

Fixed issue where component generation was incorrectly referencing Ht…

3106cf3

…ml components

jackparmer merged commit d884140 into plotly:dev Sep 7, 2021

alexcjohnson reviewed Sep 10, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Component Generation #16

Component Generation #16

plt-joey commented Jun 29, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kunjee17 commented Sep 7, 2021

This comment has been minimized.

alexcjohnson Sep 10, 2021

plt-joey Sep 10, 2021

alexcjohnson Sep 10, 2021

Component Generation #16

Component Generation #16

Conversation

plt-joey commented Jun 29, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kunjee17 commented Sep 7, 2021

This comment has been minimized.

alexcjohnson Sep 10, 2021

Choose a reason for hiding this comment

plt-joey Sep 10, 2021

Choose a reason for hiding this comment

alexcjohnson Sep 10, 2021

Choose a reason for hiding this comment

plt-joey commented Jun 29, 2021 •

edited

Loading