Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Issue 564 - Customizable column filtering logical operator #751

Merged
merged 10 commits into from
Apr 21, 2020

Conversation

Marc-Andre-Rivet
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet commented Apr 17, 2020

Closes #564

Expands on the filter_action prop to allow choosing the logical operator used between the column filters. The prop accepts the old values native, custom, none but now also allow

{
    type: 'native' | 'custom',
    operator: 'and' | 'or'
}

For backward compatibility purposes, if the operator is not defined or if the old values are used, the operator defaults to and.

This should allow for further extensions in the future, for example, if we add a column filter menu that allows more complex per-column conditions, this could be represented with something like:

{
    ...
    ui: 'input' | 'menu'
}

@Marc-Andre-Rivet Marc-Andre-Rivet changed the title [WIP] Issue 564 - Customizable column filtering logical operator Issue 564 - Customizable column filtering logical operator Apr 17, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review April 17, 2020 03:37
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 LGTM!

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit 059103a into dev Apr 21, 2020
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 564-filter-logical-operators branch April 21, 2020 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] UI for selecting && or || between filters
2 participants