Update font URLs and add additional error handling #7418
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,97 +1,82 @@ | ||
| import os | ||
|
|
||
| import requests | ||
|
|
||
| dir_out = ".circleci/fonts/truetype/googleFonts/" | ||
|
|
||
|
|
||
| def download(repo, family, types): | ||
| for t in types: | ||
| name = family + t + ".ttf" | ||
| url = repo + name + "?raw=true" | ||
| outfile = dir_out + name | ||
| print("Getting: ", url) | ||
| if os.path.exists(outfile): | ||
| print(" => Already exists: ", outfile) | ||
|
There was a problem hiding this comment. rather than overwrite (I don't know how often font files themselves update)? There was a problem hiding this comment. I did this instead of removing the download step from the CI; in other words, the download script will still run but it will not actually attempt to download the fonts because they are already in the repo. I could alternatively modify the script to overwrite, and remove the step that runs the script from the CI. I liked this approach though because it's easier to revert if we change our minds about keeping the fonts in the repo. I don't think we're worried about the font files being updated all that often... if we were I wouldn't want to put them in the repo. |
||
| continue | ||
| req = requests.get(url, allow_redirects=False) | ||
| if req.status_code != 200: | ||
| # If we get a redirect, print an error so that we know to update the URL | ||
| if req.status_code == 302 or req.status_code == 301: | ||
| new_url = req.headers.get("Location") | ||
| print(f" => Redirected -- please update URL to: {new_url}") | ||
| raise RuntimeError(f""" | ||
| Download failed. | ||
| Status code: {req.status_code} | ||
| Message: {req.reason} | ||
| """) | ||
| open(outfile, "wb").write(req.content) | ||
|
|
||
|
|
||
| download( | ||
| "https://cdn.jsdelivr.net/gh/notofonts/notofonts.github.io/fonts/NotoSansMono/hinted/ttf/", | ||
| "NotoSansMono", | ||
| ["-Regular", "-Bold"], | ||
| ) | ||
|
|
||
| download( | ||
| "https://cdn.jsdelivr.net/gh/notofonts/notofonts.github.io/fonts/NotoSans/hinted/ttf/", | ||
| "NotoSans", | ||
| ["-Regular", "-Italic", "-Bold"], | ||
| ) | ||
|
|
||
| download( | ||
| "https://cdn.jsdelivr.net/gh/notofonts/notofonts.github.io/fonts/NotoSerif/hinted/ttf/", | ||
| "NotoSerif", | ||
| [ | ||
| "-Regular", | ||
| "-Italic", | ||
| "-Bold", | ||
| "-BoldItalic", | ||
| ], | ||
| ) | ||
|
|
||
| download( | ||
| "https://raw.githubusercontent.com/google/fonts/refs/heads/main/ofl/oldstandardtt/", | ||
| "OldStandard", | ||
| ["-Regular", "-Italic", "-Bold"], | ||
| ) | ||
|
|
||
| download( | ||
| "https://raw.githubusercontent.com/google/fonts/refs/heads/main/ofl/ptsansnarrow/", | ||
| "PT_Sans-Narrow-Web", | ||
| ["-Regular", "-Bold"], | ||
| ) | ||
|
|
||
| download( | ||
| "https://raw.githubusercontent.com/impallari/Raleway/refs/heads/master/fonts/v3.000%20Fontlab/TTF/", | ||
| "Raleway", | ||
| ["-Regular", "-Regular-Italic", "-Bold", "-Bold-Italic"], | ||
| ) | ||
|
|
||
| download( | ||
| "https://raw.githubusercontent.com/googlefonts/roboto-2/refs/heads/main/src/hinted/", | ||
| "Roboto", | ||
| ["-Regular", "-Italic", "-Bold", "-BoldItalic"], | ||
| ) | ||
|
|
||
| download( | ||
| "https://raw.githubusercontent.com/expo/google-fonts/refs/heads/main/font-packages/gravitas-one/400Regular/", | ||
| "GravitasOne", | ||
| ["_400Regular"], | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI was failing with a message about "Chrome failed to start" and this resolved the issue; in any case, it seems good to keep the Chrome version somewhat up to date.