Skip to content

[i18n] Add i18n to JavaScript to make the code more readable #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[i18n] Add i18n to JavaScript to make the code more readable #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cdc7ed
Add i18n to JavaScript to make the code more readable
pedro-mendonca Nov 24, 2023
ca3961e
Merge branch 'develop' into i18n
stklcode Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions inc/class-antivirus.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,24 +356,15 @@ public static function add_enqueue_script() {
$data['Version']
);

// Sets translated strings for the script.
wp_set_script_translations( 'av_script', 'antivirus' );

// Localize script data.
wp_localize_script(
'av_script',
'av_settings',
array(
'nonce' => wp_create_nonce( 'av_ajax_nonce' ),
'labels' => array(
'dismiss' => esc_js( __( 'Dismiss', 'antivirus' ) ),
'complete' => esc_js( __( 'Scan finished', 'antivirus' ) ),
'file' => esc_js( __( 'Theme File', 'antivirus' ) ),
'status' => esc_js( __( 'Check Status', 'antivirus' ) ),
),
'texts' => array(
'dismiss' => esc_js( __( 'Dismiss false positive virus detection', 'antivirus' ) ),
'ok' => esc_js( __( '✔ OK', 'antivirus' ) ),
'pending' => esc_js( __( 'pending', 'antivirus' ) ),
'warning' => esc_js( __( '! Warning', 'antivirus' ) ),
),
)
);
}
Expand Down
33 changes: 22 additions & 11 deletions js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jQuery(document).ready(($) => {
'av-status-pending'
);
row.find('td.av-status-column').text(
av_settings.texts.warning
wp.i18n.__('! Warning', 'antivirus')
);

// Initialize lines of current file.
Expand All @@ -58,9 +58,12 @@ jQuery(document).ready(($) => {
'</code> <a href="#" id="av-dismiss-' +
md5 +
'" class="button" title="' +
av_settings.texts.dismiss +
wp.i18n.__(
'Dismiss false positive virus detection',
'antivirus'
) +
'">' +
av_settings.labels.dismiss +
wp.i18n.__('Dismiss', 'antivirus') +
'</a></p>'
);

Expand Down Expand Up @@ -100,7 +103,9 @@ jQuery(document).ready(($) => {
.removeClass('av-status-warning');
col.parent()
.find('td.av-status-column')
.text(av_settings.texts.ok);
.text(
wp.i18n.__('✔ OK', 'antivirus')
);
}
}
);
Expand All @@ -113,7 +118,9 @@ jQuery(document).ready(($) => {
row.addClass('av-status-ok').removeClass(
'av-status-pending'
);
row.find('td.av-status-column').text(av_settings.texts.ok);
row.find('td.av-status-column').text(
wp.i18n.__('✔ OK', 'antivirus')
);
}

// Increment counter.
Expand All @@ -124,7 +131,7 @@ jQuery(document).ready(($) => {
$('#av-scan-process')
.html(
'<span class="av-scan-complete">' +
av_settings.labels.complete +
wp.i18n.__('Scan finished', 'antivirus') +
'</span>'
)
.fadeOut()
Expand Down Expand Up @@ -157,8 +164,12 @@ jQuery(document).ready(($) => {
'<table class="wp-list-table widefat fixed striped table-view-list av-scan-results">' +
'<thead><tr class="av-status-pending">' +
'<td class="av-toggle-column check-column"></td>' +
'<th class="av-file-column">Theme File</th>' +
'<th class="av-status-column">Check Status</th>' +
'<th class="av-file-column">' +
wp.i18n.__('Theme File', 'antivirus') +
'</th>' +
'<th class="av-status-column">' +
wp.i18n.__('Check Status', 'antivirus') +
'</th>' +
'</tr></thead>' +
'<tbody>';

Expand Down Expand Up @@ -187,7 +198,7 @@ jQuery(document).ready(($) => {
val +
'</td>' +
'<td class="av-status-column">' +
av_settings.texts.pending +
wp.i18n.__('pending', 'antivirus') +
'</td>' +
'</tr>';
});
Expand All @@ -196,9 +207,9 @@ jQuery(document).ready(($) => {
'</tbody><tfoot><tr>' +
'<td class="av-toggle-column check-column"></td>' +
'<th class="av-file-column">' +
av_settings.labels.file +
wp.i18n.__('Theme File', 'antivirus') +
'</th><th class="av-status-column">' +
av_settings.labels.status +
wp.i18n.__('Check Status', 'antivirus') +
'</th></tr></tfoot></table>';

// assign values.
Expand Down
Loading