Use prefixed Redis keys to prevent data loss on cache clearing. #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now only the entries that belong to the current host are removed from the cache.
sdellenb
commented
Mar 8, 2025
| @self::$_redis->flushAll(); | ||
| /* Delete all cache entries for this site */ | ||
| $host = wp_unslash( $_SERVER['HTTP_HOST'] ); | ||
| $keys = self::$_redis->keys( $host . '*' ); |
There was a problem hiding this comment.
keys() returns the keys with the configured prefix, but del() or unlink() do not expect it and will add it again before sending the command to Redis.
This quirk of phpredis was discussed in phpredis/phpredis#1117 (comment) and only has to be considered when bulk-deleting.
Copy the phpcs:ignore from `_file_path()` and split the multi-line function arguments properly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only cachify entries that belong to the current host are removed from the cache.