merge hooks for flush icon style and script and use plugin version instead of filemtime #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resources of the same version should be the same, no matter if the files are touched or the plugin is re-installed. There are even scenarios where the modification time is not reliable. Reduce overhead of accessing the file system and simply add the plugin's version to scripts and styles.
stklcode
added a commit
that referenced
this pull request
Apr 16, 2025
stklcode
added a commit
that referenced
this pull request
Apr 16, 2025
Resources of the same version should be the same, no matter if the files are touched or the plugin is re-installed. There are even scenarios where the modification time is not reliable. Reduce overhead of accessing the file system and simply add the plugin's version to scripts and styles.
stklcode
force-pushed
the
refactor/resources
branch
from
4de3a3e to
9379c55
Compare
Some users experience issues with the flush icon resources. We currently register all in the "init" phase, but enqueue in 3 different places. Merge both style and script into `add_flush_icon_script`, attach it to `wp_enqueue_scripts` and also add a call from `admin_enqueue_scripts`.
stklcode
force-pushed
the
refactor/resources
branch
from
9379c55 to
219e846
Compare
Depending on the actual rendering sequence, users might run into a race condition where the admin bar element is not rendered at the time of script execution. Move the IIFE logic into a DOMContentLoaded event listener and add a check for the existence of the admin bar element to prevent errors.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and sideshows of #312.
We have a
admin_bar_menuhook to add the "flush cache" icon including stylesheet and another hook in the same phase to add the script.We also determine file modification times of all 3 resources using
filemtime()on the CSS/JS file.And finally, a possible race condition inside the Javascript, if the icon is not rendered before script excution.
CACHIFY_VERSIONinstead of dynamic timestamps.wp_enqueue_scripts/admin_qneueue_scriptsphase.