migrate to PSR-4 namespace and use Composer in production#261
Draft
migrate to PSR-4 namespace and use Composer in production#261
Conversation
Remove the "Statify_" prefix from classnames, so Statify_Frontend is now located at Statify\Frontend. Disable the corresponding PHPCS rule as it conflicts with PSR-4 standard. Remove the custom autoloader function.
Contributor
|
A small suggestion: I would stick to |
Contributor
Author
|
Good point. |
77049c0 to
9a8a06c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
I would vote to go with the minimal approach from #260 for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








This PR is WORK IN PROGRESS and not yet ready to be merged.
This proposal does change the project structure and class names.
First we introduce a
Pluginkollektiv\Statify\namespace and move the classes into it stripping their prefixes, i.e.Statify_Frontendwill becomePluginkollektiv\Statify\Frontend.Then we introduce a PSR-4 autoloader with Composer and replace our custom autoloading function.
ToDo: