use the apt_repository module instead of lineinfile module #16

arbabnazar · 2016-10-11T00:57:27Z

@JaveriaK this time I am sending small PR because it's easy for you people to test it and merge in your master branch, last time big PR with a lot of changes got delayed and a lot of conflicts occur between my PR and master so that I have closed that and now created this. Please review the PR and let me know, if you want any modification but it's really straight forward. Thanks

arbabnazar · 2016-10-11T00:58:36Z

plumgrid_playbooks/enable_pg_extensions.yml

-      apt:
-        update_cache: yes
+    - name: Add PLUMgrid openstack to repo
+      apt_repository:


Ansible has dedicated module for adding the repo. is there any specific reason to use the manual method aka lineinfile module?

No, no specific reason. You are right, dedicated module should be used.

arbabnazar · 2016-10-11T01:00:55Z

plumgrid_playbooks/enable_pg_extensions.yml


-    - name: Running apt-update
-      apt:
-        update_cache: yes


no reason to use it as apt_repository module has default update_cache

arbabnazar · 2016-10-11T01:02:33Z

plumgrid_playbooks/roles/plumgrid_neutron/tasks/main.yml

+    repo: "{{ item }}"
+    filename: plumgrid
+    state: present
+  with_items:


Instead of adding one by one, use the with_items with the apt_repository module to add all the repos.

arbabnazar · 2016-10-11T01:06:33Z

plumgrid_playbooks/enable_pg_extensions.yml

-        state: present
-        create: yes
-
    - name: Copy PLUMgrid GPG-key file


@JaveriaK instead of copying the GPG key to the server and then add it using can simply upload the public part of your GPG key to the public GPG key server like keyserver.ubuntu.com and then directly get it from there like this:

- name: Add Plumgrid PPA apt key apt_key: id: "AA798760" keyserver: "keyserver.ubuntu.com" state: present

Hi Arbab, thanks for your comments.
Every release of our software has a different GPG key. Making it static would mean we have to manually change it every time for a new release. Also, once we make it static, we wont be able to install previous version of our software with these playbooks.

@syedalijabir is there any reason that you are using different GPG for each release?

@arbabnazar Oh yes, you are right. @JaveriaK its +1 from my side.

syedalijabir · 2016-10-13T10:33:47Z

plumgrid_playbooks/enable_pg_extensions.yml

-        state: present
-        create: yes
-
    - name: Copy PLUMgrid GPG-key file


Hi Arbab, thanks for your comments.
Every release of our software has a different GPG key. Making it static would mean we have to manually change it every time for a new release. Also, once we make it static, we wont be able to install previous version of our software with these playbooks.

syedalijabir · 2016-10-13T10:35:14Z

plumgrid_playbooks/enable_pg_extensions.yml


-    - name: Running apt-update
-      apt:
-        update_cache: yes


syedalijabir · 2016-10-13T10:38:30Z

plumgrid_playbooks/enable_pg_extensions.yml

-      apt:
-        update_cache: yes
+    - name: Add PLUMgrid openstack to repo
+      apt_repository:


No, no specific reason. You are right, dedicated module should be used.

syedalijabir · 2016-10-13T10:41:16Z

plumgrid_playbooks/roles/plumgrid_neutron/tasks/main.yml

+    repo: "{{ item }}"
+    filename: plumgrid
+    state: present
+  with_items:


arbabnazar · 2016-10-17T21:12:28Z

@JaveriaK pinging on this, if you need any modification from my side. Thanks

JaveriaK · 2016-10-17T21:31:02Z

@arbabnazar thank you for your contribution. @syedalijabir is going through it and will get back to you with any feedback

syedalijabir · 2016-10-18T02:02:45Z

Hey @arbabnazar, regarding your GPG key query, we sign our debian packages with an internal key that is relevant only to the local deployments so the key changes with our different builds/releases.
Other than this your commit is good to go.

arbabnazar · 2016-10-18T16:28:03Z

@JaveriaK @syedalijabir I'll tell you better way to manage the GPG key for signing the debian packages and also share the way that how I am managing my debain PPA with sign package in next PR. Can you please merge it, if you think that it's good enough to get place in your master branch 😄

syedalijabir · 2016-10-20T17:30:44Z

@arbabnazar, we really appreciate your commit :) and as I said, its good to go into master minus the GPG key. We are all ears on your suggestion regarding a better way to manage GPG key signing.

arbabnazar · 2016-10-20T17:38:11Z

@syedalijabir I didn't change anything regarding GPG in this PR, I was just suggesting different way. I think, it's good to merge in master, please let me know if you want any change.

syedalijabir · 2016-10-20T17:57:04Z

plumgrid_playbooks/enable_pg_extensions.yml

-        state: present
-        create: yes
-
    - name: Copy PLUMgrid GPG-key file


@arbabnazar Oh yes, you are right. @JaveriaK its +1 from my side.

JaveriaK · 2016-10-22T00:58:13Z

@syedalijabir please confirm after a testing run if this is good to merge.

syedalijabir · 2016-10-26T07:56:25Z

Hi @arbabnazar , I was verifying your commit on our master branch and I hit this issue.
TASK: [plumgrid_common | Create PLUMgrid sources.list] ************************
failed: [infra1]
msg: unsupported parameter for module: filename

Kindly address this issue.

arbabnazar · 2016-10-26T15:32:17Z

@syedalijabir I think, you are using the old version of ansible, filename was introduced in 2.1 back in May 2016. Please update your version to latest stable ansible and test again, if you will still see the problem, please let me know.

syedalijabir · 2016-10-26T18:36:55Z

@arbabnazar , PLUMgrid's ONS plugin gets integrated into OpenStack Ansible (OSA). So we have to go with the same version (1.9.4) as them to avoid conflicts.

arbabnazar · 2016-10-26T19:47:26Z

@syedalijabir is it a public or private plugin? if public, please share it with me so I can make it compatible with ansible 2.x

syedalijabir · 2016-10-27T01:22:31Z

No, it is proprietary.

Javeria Khan and others added 2 commits September 27, 2016 10:27

Update openstack-ansible app-plumgrid link

adab991

use the apt_repository module instead of lineinfile module

5a66bbf

arbabnazar commented Oct 11, 2016

View reviewed changes

syedalijabir suggested changes Oct 13, 2016

View reviewed changes

syedalijabir approved these changes Oct 20, 2016

View reviewed changes

JaveriaK force-pushed the master branch from 5de413a to 8b2968d Compare November 3, 2016 21:51

use the apt_repository module instead of lineinfile module #16

Are you sure you want to change the base?

use the apt_repository module instead of lineinfile module #16

Uh oh!

Conversation

arbabnazar commented Oct 11, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arbabnazar commented Oct 17, 2016

Uh oh!

JaveriaK commented Oct 17, 2016

Uh oh!

syedalijabir commented Oct 18, 2016

Uh oh!

arbabnazar commented Oct 18, 2016

Uh oh!

syedalijabir commented Oct 20, 2016

Uh oh!

arbabnazar commented Oct 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaveriaK commented Oct 22, 2016

Uh oh!

syedalijabir commented Oct 26, 2016

Uh oh!

arbabnazar commented Oct 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

syedalijabir commented Oct 26, 2016

Uh oh!

arbabnazar commented Oct 26, 2016

Uh oh!

syedalijabir commented Oct 27, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arbabnazar commented Oct 26, 2016 •

edited

Loading