updated homepage for workbenches - #3496
Conversation
5b68a3e to
8e6c453
Compare
Greptile SummaryThis PR graduates Workbenches from a feature-flag opt-in to a first-class experience: a new Confidence Score: 5/5Safe to merge; no logic bugs or security issues found. All findings are P2 style/UX suggestions. Core routing logic, RBAC scoping, and state management are correct. The backend resolver validates bounds and uses existing query helpers correctly. No files require special attention.
|
| Filename | Overview |
|---|---|
| assets/src/components/home/HomeWorkbenches.tsx | New workbench-focused homepage with recent jobs and workbench cards; well-structured with appropriate loading skeletons and polling |
| assets/src/components/cd/clusters/Clusters.tsx | Adds optional charts panel (ClustersCharts) gated on user homepage setting; persisted show/hide state; TabPanel removed in favour of simpler WrapWithIf |
| assets/src/components/cd/clusters/ClustersCharts.tsx | New component rendering health-score heatmap and upgrade radial bar inside a SimpleAccordion; fetches data with polling; correctly scoped to projectId |
| assets/src/components/home/Home.tsx | Routes to HomeWorkbenches or HomeClusters based on me.homepage; clean and minimal |
| assets/src/components/settings/global/GlobalSettingsGeneral.tsx | Absorbs theme-mode toggle from ProfileMenu; homepage saved via mutation, theme mode applied client-side only on save; logic is correct |
| assets/src/components/cd/services/ClustersFilters.tsx | Replaces SubTab/TabList with Select dropdowns for health and upgrade filters; removes tabStateRef dependency |
| lib/console/graphql/resolvers/deployments/workbench.ex | Adds recent_workbench_jobs resolver with count validation (1–20); uses for_user RBAC scoping and ordered/with_limit query helpers |
| assets/src/components/layout/ProfileMenu.tsx | Dark/light theme toggle removed from profile menu dropdown and centralised in GlobalSettingsGeneral; clean removal |
| assets/src/components/flows/FeatureFlagContext.tsx | Workbenches feature flag removed; feature is now generally available |
| assets/src/components/home/clusteroverview/ClusterHealthScoresHeatmap.tsx | Adds showLegend prop and wraps TreeMap in a Flex column; legend reuses ChartLegendItem |
Reviews (3): Last reviewed commit: "fix conflicts" | Re-trigger Greptile
ab52baf to
841d281
Compare
623484b to
72c4040
Compare
2903b39 to
de0ac5d
Compare
de0ac5d to
e099a14
Compare
0402277 to
fc9fd5f
Compare
27c1de6 to
bcc00c6
Compare
bcc00c6 to
3645251
Compare
8354851 to
cd8eaa9
Compare
updates home page to focus more on workbenches (depending on user setting)
adds the home page charts to cd clusters view if user is set to workbenches home page
Plural Flow: console