Skip to content

updated homepage for workbenches - #3496

Merged
michaeljguarino merged 21 commits into
masterfrom
jake/prod-4742-homepage-redesign-focused-on-workbench
May 2, 2026
Merged

updated homepage for workbenches#3496
michaeljguarino merged 21 commits into
masterfrom
jake/prod-4742-homepage-redesign-focused-on-workbench

Conversation

@jsladerman

@jsladerman jsladerman commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

updates home page to focus more on workbenches (depending on user setting)
adds the home page charts to cd clusters view if user is set to workbenches home page
Plural Flow: console

@jsladerman
jsladerman requested a review from a team April 30, 2026 03:53
@jsladerman jsladerman added enhancement New feature or request frontend Changes related to the frontend labels Apr 30, 2026
@linear

linear Bot commented Apr 30, 2026

Copy link
Copy Markdown

@jsladerman
jsladerman force-pushed the jake/prod-4742-homepage-redesign-focused-on-workbench branch from 5b68a3e to 8e6c453 Compare April 30, 2026 17:10
@jsladerman jsladerman changed the title WIP: updated homepage updated homepage for workbenches Apr 30, 2026
@jsladerman
jsladerman marked this pull request as ready for review May 1, 2026 14:55
@greptile-apps

greptile-apps Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR graduates Workbenches from a feature-flag opt-in to a first-class experience: a new HomeWorkbenches page replaces the cluster overview for users who select the Workbenches home preference, cluster charts are surfaced inline on the CD Clusters view for those users, and the sidebar/command palette entries become unconditional. Supporting changes include moving the theme toggle into GlobalSettingsGeneral, refactoring the cluster status filters from tabs to dropdowns, and adding the recentWorkbenchJobs backend query with proper count validation and RBAC scoping.

Confidence Score: 5/5

Safe to merge; no logic bugs or security issues found.

All findings are P2 style/UX suggestions. Core routing logic, RBAC scoping, and state management are correct. The backend resolver validates bounds and uses existing query helpers correctly.

No files require special attention.

Important Files Changed

Filename Overview
assets/src/components/home/HomeWorkbenches.tsx New workbench-focused homepage with recent jobs and workbench cards; well-structured with appropriate loading skeletons and polling
assets/src/components/cd/clusters/Clusters.tsx Adds optional charts panel (ClustersCharts) gated on user homepage setting; persisted show/hide state; TabPanel removed in favour of simpler WrapWithIf
assets/src/components/cd/clusters/ClustersCharts.tsx New component rendering health-score heatmap and upgrade radial bar inside a SimpleAccordion; fetches data with polling; correctly scoped to projectId
assets/src/components/home/Home.tsx Routes to HomeWorkbenches or HomeClusters based on me.homepage; clean and minimal
assets/src/components/settings/global/GlobalSettingsGeneral.tsx Absorbs theme-mode toggle from ProfileMenu; homepage saved via mutation, theme mode applied client-side only on save; logic is correct
assets/src/components/cd/services/ClustersFilters.tsx Replaces SubTab/TabList with Select dropdowns for health and upgrade filters; removes tabStateRef dependency
lib/console/graphql/resolvers/deployments/workbench.ex Adds recent_workbench_jobs resolver with count validation (1–20); uses for_user RBAC scoping and ordered/with_limit query helpers
assets/src/components/layout/ProfileMenu.tsx Dark/light theme toggle removed from profile menu dropdown and centralised in GlobalSettingsGeneral; clean removal
assets/src/components/flows/FeatureFlagContext.tsx Workbenches feature flag removed; feature is now generally available
assets/src/components/home/clusteroverview/ClusterHealthScoresHeatmap.tsx Adds showLegend prop and wraps TreeMap in a Flex column; legend reuses ChartLegendItem

Reviews (3): Last reviewed commit: "fix conflicts" | Re-trigger Greptile

Comment thread assets/src/components/settings/global/GlobalSettingsGeneral.tsx
Comment thread assets/src/components/home/Home.tsx
Comment thread assets/src/components/settings/global/GlobalSettingsGeneral.tsx
@jsladerman
jsladerman force-pushed the jake/prod-4742-homepage-redesign-focused-on-workbench branch from ab52baf to 841d281 Compare May 1, 2026 15:25
@jsladerman

Copy link
Copy Markdown
Collaborator Author

@greptileai

Comment thread assets/src/components/cd/clusters/Clusters.tsx
@jsladerman

Copy link
Copy Markdown
Collaborator Author

@greptileai

@michaeljguarino
michaeljguarino force-pushed the jake/prod-4742-homepage-redesign-focused-on-workbench branch from 623484b to 72c4040 Compare May 1, 2026 21:39
@michaeljguarino
michaeljguarino force-pushed the jake/prod-4742-homepage-redesign-focused-on-workbench branch 2 times, most recently from 2903b39 to de0ac5d Compare May 2, 2026 00:15
@michaeljguarino
michaeljguarino force-pushed the jake/prod-4742-homepage-redesign-focused-on-workbench branch from de0ac5d to e099a14 Compare May 2, 2026 01:37
@michaeljguarino
michaeljguarino requested a review from a team as a code owner May 2, 2026 02:15
@michaeljguarino
michaeljguarino force-pushed the jake/prod-4742-homepage-redesign-focused-on-workbench branch from 0402277 to fc9fd5f Compare May 2, 2026 02:21
@michaeljguarino
michaeljguarino force-pushed the jake/prod-4742-homepage-redesign-focused-on-workbench branch 4 times, most recently from 27c1de6 to bcc00c6 Compare May 2, 2026 14:53
@michaeljguarino
michaeljguarino force-pushed the jake/prod-4742-homepage-redesign-focused-on-workbench branch from bcc00c6 to 3645251 Compare May 2, 2026 14:55
@michaeljguarino
michaeljguarino force-pushed the jake/prod-4742-homepage-redesign-focused-on-workbench branch from 8354851 to cd8eaa9 Compare May 2, 2026 15:32
@michaeljguarino
michaeljguarino merged commit b15cf0b into master May 2, 2026
61 checks passed
@michaeljguarino
michaeljguarino deleted the jake/prod-4742-homepage-redesign-focused-on-workbench branch May 2, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Changes related to the frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants